feat: add timestamp to all event protos #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
This looks good, but can we add the timestamp to the EventEpochRoot and EventAnchor as well? Even if the data is duplicated across multiple events, I think it will be useful for downstream data consumers to be able to access it directly.
For instance, the difference between the time a transaction was accepted into a block and the timestamp of the anchor it proves against is an interesting measurement / information leak -- it gives info about the combined latency of proving + tx submission -- and it'd be convenient to have timestamps on every anchor.
vacekj
changed the title
cronokirby
approved these changes
Jul 18, 2024
vacekj
added a commit
that referenced
this pull request
Jul 19, 2024
cronokirby
pushed a commit
that referenced
this pull request
Jul 22, 2024
this makes a non-consensus-breaking change, adding a timestamp field to the EventBlockRoot proto. This will be used to keep track of the timestamp of the block for use in pindexer. I tested this by running a local devnet with the changes to core. Pd runs fine and the timestamps are correctly propagated to the raw events db. prerequisite for #4675 - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: - only adds a field - adds this field to an Event proto
2 tasks
cronokirby
added a commit
that referenced
this pull request
Jul 22, 2024
this makes a non-consensus-breaking change, adding a timestamp field to the EventBlockRoot proto. This will be used to keep track of the timestamp of the block for use in pindexer. I tested this by running a local devnet with the changes to core. Pd runs fine and the timestamps are correctly propagated to the raw events db. prerequisite for #4675 - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: - only adds a field - adds this field to an Event proto ## Describe your changes ## Issue ticket number and link ## Checklist before requesting a review - [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF) --------- Co-authored-by: Josef <vacekj@outlook.com> Co-authored-by: Conor Schaefer <conor@penumbralabs.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
this makes a non-consensus-breaking change, adding a timestamp field to the EventBlockRoot proto.
This will be used to keep track of the timestamp of the block for use in pindexer.
I tested this by running a local devnet with the changes to core. Pd runs fine and the timestamps are correctly propagated to the raw events db.
Issue ticket number and link
prerequisite for #4675
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
only adds a field
adds this field to an Event proto