Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] pd: fix behavior of simulation RPC #4733

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

conorsch
Copy link
Contributor

Describe your changes

Backports the RPC fix in #4731 to the release/v0.79.x branch, in preparation for v0.79.2.

Issue ticket number and link

Only #4731

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    RPC-only changes, already reviewed in pd: fix behavior of simulation RPC #4731, and should be exactly the same here.

## Describe your changes

Fixes the behavior of the simulation RPC for pairs with no liquidity, so
that the simulation results correspond to what would happen if there
were a swap.

## Issue ticket number and link

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > rpc only changes

(cherry picked from commit 2429c16)
@conorsch conorsch merged commit c34b6de into release/v0.79.x Jul 22, 2024
11 checks passed
@conorsch conorsch deleted the rpc-simulation-for-0_79 branch July 22, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants