pindexer: implement dex value circuit breaker indexing #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly just to have scaffolding for new dex events
1 task
conorsch
reviewed
Jul 24, 2024
| @@ -7,8 +7,8 @@ impl IndexerExt for cometindex::Indexer { | |||
| self.with_index(crate::shielded_pool::fmd::ClueSet {}) | |||
| .with_index(crate::stake::ValidatorSet {}) | |||
| .with_index(crate::stake::Slashings {}) | |||
| .with_index(crate::stake::MissedBlocks {}) | |||
There was a problem hiding this comment.
Why remove MissedBlocks here?
There was a problem hiding this comment.
We don't consume this in our dashboards right now, and this slows down indexing a lot, since this is a frequent event.
conorsch
approved these changes
Jul 24, 2024
aubrika
pushed a commit
that referenced
this pull request
Jul 24, 2024
Merge #4753 first. ## Describe your changes This implements indexing for arb executions in pindexer. ## Issue ticket number and link Closes #4736. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > indexing changes only --------- Co-authored-by: vacekj <vacekj@users.noreply.github.com> Co-authored-by: Atris <vacekj@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This implements a basic dex indexing component for the value circuit breaker; more importantly, this adds some basic scaffolding that other dex related indexing can latch onto.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: