docs: create pindexer readme and mention pindexer<>pd compat in errors #4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
reviewed
Jul 25, 2024
cronokirby
reviewed
Jul 25, 2024
crates/bin/pindexer/src/block.rs
Outdated
| @@ -52,7 +53,7 @@ CREATE TABLE IF NOT EXISTS block_details ( | |||
| .bind(i64::try_from(pe.height)?) | |||
| .bind( | |||
| DateTime::from_timestamp(timestamp.seconds, u32::try_from(timestamp.nanos)?) | |||
| .ok_or(anyhow!("failed to convert timestamp"))?, | |||
| .ok_or(anyhow!("failed to convert timestamp." + PD_COMPAT))?, | |||
There was a problem hiding this comment.
Suggested change
| .ok_or(anyhow!("failed to convert timestamp." + PD_COMPAT))?, | |
| .ok_or(anyhow!(format!("failed to convert timestamp. {PD_COMPAT}"))?, |
cronokirby
reviewed
Jul 25, 2024
Signed-off-by: Lúcás Meier <cronokirby@gmail.com>
cronokirby
reviewed
Jul 25, 2024
Signed-off-by: Lúcás Meier <cronokirby@gmail.com>
conorsch
deleted the
4765-mention-pdpindexer-version-mismatch-in-missing-event-property-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
adds some explanation for a common issue with pindexer
Issue ticket number and link
fixes #4765
Checklist before requesting a review
indexer-only changes