Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment missing events for governance #4769

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Augment missing events for governance #4769

merged 3 commits into from
Jul 25, 2024

Conversation

cronokirby
Copy link
Contributor

This takes the event related changes from #4708 and pulls them out for independent review and merging.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    event emission only.

cronokirby and others added 2 commits July 25, 2024 11:53
This introduces a canonical way to serialize this enum, which is useful
for storing it in a database.

Co-authored-by: plaidfinch <plaidfinch@users.noreply.github.com>
This implements a few different additions to events to make
governance-related indexing easier:
- add the validator identity key to delegator vote events
- add the voting power to validator votes
- add the start and end height to proposal submissions

This also renames the EventEnactProposal to EventProposalPassed, which
hypothetically breaks existing consumers of that event, of which we know
of none.

Co-authored-by: plaidfinch <plaidfinch@users.noreply.github.com>
@cronokirby
Copy link
Contributor Author

c.f. #4708 (comment) for discussion on the lint failure

Copy link
Contributor

@aubrika aubrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@aubrika aubrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One hesitation - are we sure renaming the EventEnactProposal proto isn't going to break anything? Seems better not to do this if we can avoid it, although semantically the change does seem like an improvement

@aubrika aubrika dismissed their stale review July 25, 2024 21:31

Was missing conversation context

@aubrika aubrika merged commit 3b21ac8 into main Jul 25, 2024
12 of 13 checks passed
@aubrika aubrika deleted the governance-events branch July 25, 2024 21:48
@hdevalence
Copy link
Member

One hesitation - are we sure renaming the EventEnactProposal proto isn't going to break anything? Seems better not to do this if we can avoid it, although semantically the change does seem like an improvement

Yes, it breaks anything that was using it, which at the time was only the code in that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants