-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Augment missing events for governance #4769
Conversation
This introduces a canonical way to serialize this enum, which is useful for storing it in a database. Co-authored-by: plaidfinch <plaidfinch@users.noreply.github.com>
This implements a few different additions to events to make governance-related indexing easier: - add the validator identity key to delegator vote events - add the voting power to validator votes - add the start and end height to proposal submissions This also renames the EventEnactProposal to EventProposalPassed, which hypothetically breaks existing consumers of that event, of which we know of none. Co-authored-by: plaidfinch <plaidfinch@users.noreply.github.com>
c.f. #4708 (comment) for discussion on the lint failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One hesitation - are we sure renaming the EventEnactProposal proto isn't going to break anything? Seems better not to do this if we can avoid it, although semantically the change does seem like an improvement
Yes, it breaks anything that was using it, which at the time was only the code in that PR |
This takes the event related changes from #4708 and pulls them out for independent review and merging.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: