fix: update dependencies in parameter-setup crate #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter-setup crate was broken due to outdated dependencies. The options here are: 1. add this tool to the workspace 2. keep the dependencies updated instead of using workspace inheritance Option 1 is more maintainable. Even though the parameters are fixed now due to mainnet, folks may try to use this for debugging - the scenario that motivated this commit.
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
TalDerei
approved these changes
Nov 18, 2024
2 tasks
conorsch
added a commit
that referenced
this pull request
Nov 19, 2024
## Describe your changes Follow-up to #4930, in which we inadvertently broken container builds, due to a workspace dependency being introduced. We don't build container images on every PR push, so CI passed fine, only failing when trying to build/deploy post-merge. Tacked on a small change to address. For testing, leave it to me: I'll re-deploy after this lands to get it going. ## Issue ticket number and link Refs #4933. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > build logic only, no changes to consensus
4 tasks
2 tasks
conorsch
added a commit
that referenced
this pull request
Nov 21, 2024
## Describe your changes Updates the package metadata for the `parameter-setup` crate, which was recently pulled into the workspace. Without these changes, `cargo-release` was failing to add a version number to the automatically generated commit message. ## Issue ticket number and link Refs #4928, #4930. ## Testing and review If you care to verify the results locally, you can: ``` git checkout -b my-feature-branch cargo release 0.80.9 --execute # this won't push anything, but will require cleanup git show # to view the commit message ``` Make sure that the generated commit message says "chore: release version 0.80.9", _not_ "chore: release version {{version}}". If you ran these steps, **you must clean up**: ``` git checkout main git tag -d v0.80.9 git branch -D my-feature-branch ``` If you forget to delete the tag, then when 0.80.9 is actually released, you won't be able to pull the tag from github. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > package metadata only, no changes to application code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The parameter-setup crate was broken due to outdated dependencies. The options here are:
Option 1 is more maintainable. Even though the parameters are fixed now due to mainnet, folks may try to use this crate for debugging - the scenario that motivated this commit.
To test: I followed the steps in https://guide.penumbra.zone/dev/parameter_setup to ensure we could run the parameter setup.
Issue ticket number and link
This was discovered while debugging #4927
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: