pindexer: insights: correct calculation of total value shielded #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
cronokirby
force-pushed
the
4925-insights
branch
from
48797ab to
61ddafb
Compare
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
cronokirby
force-pushed
the
4925-insights
branch
from
61ddafb to
b5a5172
Compare
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
2 tasks
conorsch
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This corrects the calculation of the total value shielded. Previously, were were adding the absolute value of outbound transfers, as well as refunds to the total. Instead, we just need to consider deposits.
To test, we should look at current mainnet data, and make sure that the total for USDC is changing appropriately.
Issue ticket number and link
Closes #4925
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: