Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input #8

Merged
merged 36 commits into from Jan 18, 2019
Merged

Input #8

merged 36 commits into from Jan 18, 2019

Conversation

penx
Copy link
Owner

@penx penx commented Dec 16, 2018

  • Input component, with supporting Hint, Label and ErrorMessage components.
  • Use template tests from govuk-frontend via govuk-frontend-template-spec

Note: At the moment, Jest snapshots are manually copied across. When Jest 0.24 comes out there will be a feature to allow the snapshot test location to be configured (jestjs/jest#6143), so will keep the manual process for now, with the aim to load them in from node_modules when 0.24 is out.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #8 into master will decrease coverage by 38.57%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
- Coverage     100%   61.42%   -38.58%     
===========================================
  Files           9       13        +4     
  Lines          43       70       +27     
  Branches       10       14        +4     
===========================================
  Hits           43       43               
- Misses          0       23       +23     
- Partials        0        4        +4
Impacted Files Coverage Δ
src/components/label/index.js 0% <0%> (ø)
src/components/error-message/index.js 0% <0%> (ø)
src/components/input/index.js 0% <0%> (ø)
src/components/hint/index.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635634a...b8dfed4. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9     13    +4     
  Lines          43     56   +13     
  Branches       10     15    +5     
=====================================
+ Hits           43     56   +13
Impacted Files Coverage Δ
src/components/header/index.js 100% <ø> (ø) ⬆️
src/components/button/index.js 100% <ø> (ø) ⬆️
src/components/label/index.js 100% <100%> (ø)
src/components/error-message/index.js 100% <100%> (ø)
src/components/input/index.js 100% <100%> (ø)
src/components/hint/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635634a...b0b0067. Read the comment docs.

@penx penx changed the title Initial input Input Dec 18, 2018
@@ -0,0 +1,6 @@
const { toHaveNoViolations } = require('jest-axe');
const { setRender } = require('govuk-frontend-template-spec/lib/jest-helpers');
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setRender should be exported from govuk-frontend-template-spec root

@penx penx merged commit c28935e into master Jan 18, 2019
@penx penx deleted the feature/input branch January 18, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant