A litte improvement to first patch #4

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
3 participants
@JessThrysoee

I changed my patch to invoke the handler again if img.src changes.

@JessThrysoee

This comment has been minimized.

Show comment Hide comment
@JessThrysoee

JessThrysoee Oct 23, 2010

The latest comit fixes not being able to trigger('load').

The latest comit fixes not being able to trigger('load').

@peol

This comment has been minimized.

Show comment Hide comment
@peol

peol Dec 7, 2010

Owner

I will test this thoroughly tonight when I get home, if everything checks out, I'll merge it :)

Owner

peol commented Dec 7, 2010

I will test this thoroughly tonight when I get home, if everything checks out, I'll merge it :)

@justinhillsjohnson

This comment has been minimized.

Show comment Hide comment
@justinhillsjohnson

justinhillsjohnson Dec 16, 2010

The patch is pretty solid except in FF 3.6.13. this.complete always returns true in FF, so the callback for the event listener is triggered before the image is done loading (very noticeable if you throttle your connection with Charles).

The patch is pretty solid except in FF 3.6.13. this.complete always returns true in FF, so the callback for the event listener is triggered before the image is done loading (very noticeable if you throttle your connection with Charles).

@peol peol closed this Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment