Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute settings from pipeline interface are no longer populated #184

Closed
nsheff opened this issue May 15, 2019 · 9 comments

Comments

@nsheff
Copy link
Contributor

commented May 15, 2019

compute settings from the pipeline interface are apparently no longer being populated by the submission scripts

Could be related to #54

@nsheff

This comment has been minimized.

@vreuter

This comment has been minimized.

Copy link
Member

commented May 15, 2019

For these sorts of issues, a use case (i.e., project files) is helpful for assessment. Essential, actually.

@vreuter

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Also hopefully you're on master; I'd expect dev to be nonfunctional in a variety of ways at the moment.

@vreuter

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Also there's an open question in #54 that's blocking resolution.

@nsheff nsheff assigned nsheff and vreuter and unassigned nsheff May 15, 2019

@nsheff

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

use case: try to run latest pepatac with latest looper, on singularity.

vreuter added a commit to vreuter/looper that referenced this issue May 20, 2019

@vreuter

This comment has been minimized.

Copy link
Member

commented May 20, 2019

With dev on divvy, peppy, looper, and pepatac (and attmap 0.12.3), this now appears resolved for me. From Python 2 on Rivanna:

looper run -d $HOME/code/pepatac/examples/test_project/test_config.yaml --compute-package singularity_slurm

yields the attached submission script (home path replaced).
test_pepatac.txt

@vreuter

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Word of caution...submission script tests aren't running on 2.7--which is odd since this use case produces a submission script--but just be aware that there may be some yet-unresolved corner case behavior, though it seems likely that it's specific to design in the test suite itself rather than in the main package.

@nsheff

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

awesome. thanks! I think this is worth a point release...

@nsheff

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

but yeah it seems we should double-check that 2.7 is working since that's still where everything is used mostly at this point

@nsheff nsheff referenced this issue May 20, 2019

vreuter added a commit to vreuter/looper that referenced this issue May 20, 2019

@nsheff nsheff closed this in #187 May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.