Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative pipeline interface paths should be relative to the PEP #268

Closed
nsheff opened this issue May 21, 2020 · 3 comments · Fixed by #274
Closed

relative pipeline interface paths should be relative to the PEP #268

nsheff opened this issue May 21, 2020 · 3 comments · Fixed by #274
Assignees
Labels

Comments

@nsheff
Copy link
Contributor

nsheff commented May 21, 2020

Right now, if you use a relative pipeline interface path, such as is used in the hello_looper repository, looper is assuming the piface will be relative to the current working directory, which is wrong. it should be considered relative to the PEP that specifies the piface.

@nsheff
Copy link
Contributor Author

nsheff commented Jun 16, 2020

This is not solved in my hands with the current release of looper -- at least for project pipelines. is it possible you solved it for sample pipelines but not project pipeline interfaces?

@nsheff nsheff reopened this Jun 16, 2020
@stolarczyk
Copy link
Member

stolarczyk commented Jun 16, 2020

I think it was fixed for both because they were one file at the time, but then we split sample and project pipeline interfaces..

@nsheff
Copy link
Contributor Author

nsheff commented Jun 16, 2020

makes sense. thanks.

@nsheff nsheff mentioned this issue Aug 26, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants