Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contstants in subprojects are ignored #292

Closed
nsheff opened this issue Apr 30, 2019 · 5 comments

Comments

@nsheff
Copy link
Contributor

commented Apr 30, 2019

if I define a project with constants, and then add some constants in a subproject, when I activate that subproject, the constants are not available.

Therefore, somehow, constants are being treated differently than all other parameters; these need to be unified so that subprojects work for all project attributes.

@nsheff nsheff added the bug label Apr 30, 2019

@vreuter

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Why should the action to take be "append-to-parent" rather than "replace-parent?" From a user perspective, there doesn't necessarily seem to be one assumption that's obviously more reasonable/intuitive than the other.

@nsheff

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

I didn't suggest either of those. I think we should just do it the same way we do everything else. I thought that was 'update-parent' (which adds any new ones, overrides any existing)... but anyway, that's not at issue -- in other words, I just don't think the 'constants' section should be treated differently from every other section.

@vreuter

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

I think difference in nature of the the meaning of the values necessitates differential treatment (what would it mean to "append" something like an output directory or an annotations sheet?)

@nsheff

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

I don't understand what you're saying, maybe we can talk in person?

@nsheff nsheff changed the title contstants in subprojects do not get appended to contstants in subprojects are ignored Apr 30, 2019

@vreuter vreuter self-assigned this Apr 30, 2019

@vreuter vreuter added this to the 0.21 milestone Apr 30, 2019

@vreuter

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Handle also #302

vreuter added a commit to vreuter/peppy that referenced this issue May 6, 2019

@nsheff nsheff closed this Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.