Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolate testing #2

Closed
nsheff opened this issue May 8, 2019 · 6 comments
Closed

isolate testing #2

nsheff opened this issue May 8, 2019 · 6 comments

Comments

@nsheff
Copy link
Contributor

@nsheff nsheff commented May 8, 2019

Right now the package requires pytest. This causes docs builds for all packages that use ubiquerg to require installing pytest. We should isolate this dependency to only testing.

See: pepkit/geofetch@ab2c03a

@vreuter

This comment has been minimized.

Copy link
Member

@vreuter vreuter commented May 8, 2019

I don't understand...ExpectContext is tested within this package, but it's not used by tests in this package; it's intended for import by other packages.

@nsheff

This comment has been minimized.

Copy link
Contributor Author

@nsheff nsheff commented May 8, 2019

Ok, I'm confused. I can't understand all the pytest stuff, it's too complicated for me. All I'm trying to do is fix this error:

https://readthedocs.org/projects/geofetch/builds/9035929/

And I don't think adding pytest to requirements.txt is the solution, because I don't think RTD should have to install pytest.

@vreuter

This comment has been minimized.

Copy link
Member

@vreuter vreuter commented May 8, 2019

The build should resolve itself once geofetch master is released, without changing the reqs file, as I think what you suggested worked in peppy, right?

@nsheff

This comment has been minimized.

Copy link
Contributor Author

@nsheff nsheff commented May 8, 2019

ah... but this is different because it just depends on the next ubiquerg release then, right? if you added a pytest dependency to ubiquerg?

@vreuter vreuter closed this in 7202893 May 8, 2019
@nsheff

This comment has been minimized.

Copy link
Contributor Author

@nsheff nsheff commented May 8, 2019

as an aside, though, wouldn't you rather not have pytest as a general dependency of a package and only have it as a test dependency?

@vreuter

This comment has been minimized.

Copy link
Member

@vreuter vreuter commented May 8, 2019

Not particularly...I think pytest is only slightly less central/integral than something like setuptools, and is therefore something that should essentially always be installed. That said, this sort of question is what initially motivated separate/sub installations in pypiper, basically for more granular user installation options according to desired use of ngstk, so is something that could be considered here. Again, though, I mostly think that pytest should virtually always be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.