-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use DBConnection behavior #10
Comments
Hey @fcarlislehg, thanks for opening an issue! I don't think there is a reason not to implement this as a I'd definitely be interested in seeing any attempts you make towards implementing this behaviour! |
@fcarlislehg this is partially done, but there may be some issues. If you could give it a try and report back, that would be great! |
I'm wondering if we should combine efforts. It seems that both our teams are moving in the same direction. https://github.com/HGInsights/snowpack We borrowed from snowflex and a MSSQL driver to get started on snowpack. Parsing params and results from/to Elixir types is where we have spent a decent effort. We are working on the tests now to get them to an acceptable level before publishing to hex. We also have OpenTelemetry support here: https://github.com/HGInsights/opentelemetry_snowpack |
@forest I just say your reply. We're working on a proper DBConnection implementation right now. Perhaps we can catch up and compare notes soon. |
Has there been any consideration on updating this to implement the DBConnection behavior that official adapters like Postregx do?
https://github.com/elixir-ecto/db_connection
Is there a reason NOT to implement the DBConnection behavior?
Would you be open to a pull request with this major refactor?
The text was updated successfully, but these errors were encountered: