Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use DBConnection behavior #10

Open
fcarlislehg opened this issue Mar 4, 2021 · 4 comments
Open

Update to use DBConnection behavior #10

fcarlislehg opened this issue Mar 4, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@fcarlislehg
Copy link

Has there been any consideration on updating this to implement the DBConnection behavior that official adapters like Postregx do?

https://github.com/elixir-ecto/db_connection

Is there a reason NOT to implement the DBConnection behavior?
Would you be open to a pull request with this major refactor?

@mphfish
Copy link

mphfish commented Mar 8, 2021

Hey @fcarlislehg, thanks for opening an issue!

I don't think there is a reason not to implement this as a DBConnection. I've done a little bit of research into this, and there is some prior art for using the Erlang :odbc module in a module conforming to the DBConnection behaviour.

I'd definitely be interested in seeing any attempts you make towards implementing this behaviour!

@Ch4s3
Copy link
Contributor

Ch4s3 commented May 9, 2022

@fcarlislehg this is partially done, but there may be some issues. If you could give it a try and report back, that would be great!

@forest
Copy link

forest commented May 10, 2022

I'm wondering if we should combine efforts. It seems that both our teams are moving in the same direction. https://github.com/HGInsights/snowpack

We borrowed from snowflex and a MSSQL driver to get started on snowpack. Parsing params and results from/to Elixir types is where we have spent a decent effort.

We are working on the tests now to get them to an acceptable level before publishing to hex.

We also have OpenTelemetry support here: https://github.com/HGInsights/opentelemetry_snowpack

@mphfish mphfish added the enhancement New feature or request label Jun 28, 2022
@Ch4s3
Copy link
Contributor

Ch4s3 commented Aug 4, 2022

@forest I just say your reply. We're working on a proper DBConnection implementation right now. Perhaps we can catch up and compare notes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants