This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
PMM-1986: Signing out with HTTP auth enabled leaves the browser "signed in" #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
delgod
approved these changes
Jan 27, 2018
|
LGTM. @cezmunsta, can you please sign our CLA? Just click a button in the message above. |
AlekSi
approved these changes
Jan 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HTTP authentication is enabled, the Grafana "sign out" does not work as expected, with navigation to any page other than the login page afterwards providing the user with immediate access once more.
This could leave end-users believing that they have signed-out and perhaps provide unauthorised users with access.
Using the nginx location directive to specifically handle the logout page for Grafana, we can force the browser to reauthenticate if HTTP authentication is enabled.