Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more form element serialization #146

Merged
merged 3 commits into from Sep 12, 2019

Conversation

@Robdel12
Copy link
Member

@Robdel12 Robdel12 commented Sep 11, 2019

What is this?

This brings the Ember SDK up to date with how percy-agent handles input serialization. It also follows the same pattern for not mutating the original DOM (for the most part). This will now capture:

  • All inputs (sliders, email, phone, etc)
  • Text areas
  • Selects (multiple and single)
@Robdel12 Robdel12 requested a review from wwilsman Sep 11, 2019
@Robdel12 Robdel12 force-pushed the rd/update-input-serialization branch from a186430 to bd27a11 Sep 11, 2019
@Robdel12 Robdel12 merged commit a31d5b4 into master Sep 12, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@percy
percy/ember-percy No visual changes since last approval
Details
security/snyk - package.json (timhaines) No new issues
Details
@Robdel12 Robdel12 deleted the rd/update-input-serialization branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants