Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate asset clobbering resource paths. #70

Merged
merged 5 commits into from Jul 20, 2018
Merged

Conversation

@fotinakis
Copy link
Member

@fotinakis fotinakis commented Jul 20, 2018

Fixes #68

With two identical assets stored at different paths:

Before (from new Percy integration test):

ee933711420cb505552f98457bd7721c1caab74ce7e6246cb5edcc927f5ff9fc

After (from new Percy integration test):
e50e3464527404f2fa3fa4779e6a089428f923849c5d76e1715a741373b97fe1

@fotinakis fotinakis requested a review from timhaines Jul 20, 2018
@fotinakis fotinakis merged commit ac32ea6 into master Jul 20, 2018
4 of 6 checks passed
4 of 6 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@percy
percy/ember-percy Visual review approved by Mike Fotinakis
Details
security/snyk - package.json (timhaines) No new issues
Details
@fotinakis fotinakis deleted the fix-asset-clobbering branch Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant