Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Percy for PeerIQ #71

Merged
merged 3 commits into from Sep 7, 2018
Merged

Fix Percy for PeerIQ #71

merged 3 commits into from Sep 7, 2018

Conversation

@Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Aug 10, 2018

For #51

This just adds a little defensive programming for when config hook isn't called or has wrong config.

@fotinakis
Copy link
Member

@fotinakis fotinakis commented Sep 7, 2018

This shouldn't be necessary, but also is not harmful and if it solves your issue then great. I'll merge this as soon as tests pass, and we'll be doing a release of the next version of ember-percy next Wednesday.

@fotinakis fotinakis mentioned this pull request Sep 7, 2018
@fotinakis fotinakis merged commit 1b7ed75 into percy:master Sep 7, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (timhaines) No manifest changes detected
@Gaurav0 Gaurav0 deleted the Gaurav0:fix_percy_for_peeriq branch Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants