From 36916ca82dfecffbbb241f94b99b426aba0cf636 Mon Sep 17 00:00:00 2001 From: Chinmay Maheshwari Date: Mon, 12 Jun 2023 19:44:59 +0530 Subject: [PATCH] Fix all linting issues --- Percy/Percy.cs | 2 +- Percy/PercyDriver.cs | 2 +- Percy/PercySeleniumDriver.cs | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Percy/Percy.cs b/Percy/Percy.cs index 619d2c3..1b9565f 100644 --- a/Percy/Percy.cs +++ b/Percy/Percy.cs @@ -42,7 +42,7 @@ private static string PayloadParser(object? payload = null, bool alreadyJson = f { if (alreadyJson) { - return payload.ToString(); + return payload is null ? "" : payload.ToString(); } return JsonSerializer.Serialize(payload).ToString(); } diff --git a/Percy/PercyDriver.cs b/Percy/PercyDriver.cs index 2265238..bbb4384 100644 --- a/Percy/PercyDriver.cs +++ b/Percy/PercyDriver.cs @@ -8,7 +8,7 @@ namespace PercyIO.Selenium public class PercyDriver { private IPercySeleniumDriver percySeleniumDriver; - private String sessionId; + private String sessionId = ""; internal void setValues(IPercySeleniumDriver percySeleniumDriver) { this.sessionId = percySeleniumDriver.sessionId(); diff --git a/Percy/PercySeleniumDriver.cs b/Percy/PercySeleniumDriver.cs index df3a5b0..4587423 100644 --- a/Percy/PercySeleniumDriver.cs +++ b/Percy/PercySeleniumDriver.cs @@ -25,13 +25,13 @@ public RemoteWebDriver getRemoteWebDriver() public ICapabilities GetCapabilities() { // Implement Cache - return this._remoteDriver?.Capabilities; + return this._remoteDriver.Capabilities; } public IDictionary GetSessionDetails() { // Implement Cache - return (IDictionary)this._remoteDriver?.Capabilities; + return (IDictionary)this._remoteDriver.Capabilities; } public String sessionId() @@ -41,9 +41,9 @@ public String sessionId() public String GetHost() { - HttpCommandExecutor executor = (HttpCommandExecutor)(this._remoteDriver)?.CommandExecutor; - FieldInfo remoteServerUriField = typeof(HttpCommandExecutor)?.GetField("remoteServerUri", BindingFlags.NonPublic | BindingFlags.Instance); - String commandExecutorUrl = remoteServerUriField?.GetValue(executor)?.ToString(); + HttpCommandExecutor executor = (HttpCommandExecutor)(this._remoteDriver).CommandExecutor; + FieldInfo remoteServerUriField = typeof(HttpCommandExecutor).GetField("remoteServerUri", BindingFlags.NonPublic | BindingFlags.Instance); + String commandExecutorUrl = remoteServerUriField.GetValue(executor).ToString(); return commandExecutorUrl; } }