Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.getAccountTransaction results in an error #41

Open
toshirot opened this issue Sep 4, 2019 · 4 comments · May be fixed by #46

Comments

@toshirot
Copy link

@toshirot toshirot commented Sep 4, 2019

this code worked on 2019-09-01, but now I get an error.

code test-tx.js

  const libracore =require('libra-core')

  const client = new libracore.LibraClient({ network: libracore.LibraNetwork.Testnet });
  const accountAddress = '7f58df27522872ecfac340c5c072427e6f8083ca3c79bb748cdd1ae073dacc42';
  const sequenceNumber = 43; //can also use a string for really large sequence numbers;

  const transaction = client.getAccountTransaction(accountAddress, sequenceNumber); 

Run

node test-tx.js

Error

/home/tato/kabuda.net/html/test/libra/libra-core/node_modules/libra-core/build/client/Decoder.js:39
        const signedTransaction = signedTransactionWP.getSignedTransaction();
                                                      ^

TypeError: Cannot read property 'getSignedTransaction' of undefined
    at ClientDecoder.decodeSignedTransactionWithProof (/home/tato/kabuda.net/html/test/libra/libra-core/node_modules/libra-core/build/client/Decoder.js:39:55)
    at /home/tato/kabuda.net/html/test/libra/libra-core/node_modules/libra-core/build/client/index.js:109:38
    at Object.onReceiveStatus (/home/tato/kabuda.net/html/test/libra/libra-core/node_modules/grpc/src/client_interceptors.js:1207:9)
    at InterceptingListener._callNext (/home/tato/kabuda.net/html/test/libra/libra-core/node_modules/grpc/src/client_interceptors.js:568:42)
    at InterceptingListener.onReceiveStatus (/home/tato/kabuda.net/html/test/libra/libra-core/node_modules/grpc/src/client_interceptors.js:618:8)
    at callback (/home/tato/kabuda.net/html/test/libra/libra-core/node_modules/grpc/src/client_interceptors.js:845:24)
@toshirot

This comment has been minimized.

Copy link
Author

@toshirot toshirot commented Sep 5, 2019

Maybe this testnet-update-september-4th effect? https://community.libra.org/t/testnet-update-september-4th/1630

  • [crypto] Switches LedgerInfo to nextgen_crypto #373 libra/libra#373 21
  • [crypto] Changes types::SignedTransaction to use the nextgen crypto API #429 libra/libra#429 17
  • [crypto] apply nextgen_crypto x25519 across Libra #464 libra/libra#464 13
  • [storage][execution] Switch to Jellyfish Merkle Tree #516 libra/libra#516 11
  • [common] Add Canonical Serialization Spec #622 libra/libra#622 9
  • Use CanonicalSerialization of RawTransaction between client and validator #606 libra/libra#606 17
@glachac

This comment has been minimized.

Copy link

@glachac glachac commented Sep 5, 2019

The Libra testnet was reset. There are no old transactions. I took the address from your sample, and the current sequence number is zero.

This exception you are seeing is because the getSignedTransaction() method does not check if the returned GRPC call contains a valid signedTransactionWP, and it winds up getting a null-value. If it checked for null, it could return an error and not an exception.

You can see the lack of transactions on that address using LibExplorer:
https://libexplorer.com/address/7f58df27522872ecfac340c5c072427e6f8083ca3c79bb748cdd1ae073dacc42

The testnet update does appear to break the current libra-core, and you can't perform any transactions at the moment.

@toshirot

This comment has been minimized.

Copy link
Author

@toshirot toshirot commented Sep 6, 2019

@glachac Thank you for your advice.

I watched LibExplorer. Certainly, there are no transactions.
I tried to create a sequence by transferring after minting with another address for trial, but I couldn't. I can mint.

toshirot added a commit to toshirot/libra-auth that referenced this issue Sep 6, 2019
fix follow, to make stub for connections to telnet.

2019-09-05 This demo currently stops with transaction-related errors. @see perfectmak/libra-core#41
@glachac

This comment has been minimized.

Copy link

@glachac glachac commented Sep 6, 2019

I have a PR with a fix for this now.

@glachac glachac referenced a pull request that will close this issue Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.