_pm_ispartition() heulistic miss some block devices

[moriwaka]

In src/pmdas/linux/proc_partitions.c, _pm_ispartition() use heulistic to detect partitions, but this misses some block devices like "sr0", "scd0", "fd0" etc.
I suggest using sysfs. /sys/block/* listing all block devices.

Thanks,

[natoscott]

I believe this was done purposefully, because floppy disk, CDROM, and DVD devices are not typically of interest in general purpose performance analysis tools. Do you have a need for the per-partition values from those devices?

[moriwaka]

I noticed this by difference of pmiostat and iostat outputs. I agree with you, CD,DVD,FDs are not interested in almost all use case. To now, I don't have real needs nor problems.

I thought that new devices' or some special drivers' naming rules are uncontrollable. And proper block device detection method can be help for minor devices and users.

Thanks,

[natoscott]

I thought that new devices' or some special drivers' naming rules are uncontrollable.
And proper block device detection method can be help for minor devices and users.

Yes, this could certainly be done and would be an improvement I think. We would need to ensure the current code remains though, as it will need to run on older kernels lacking sysfs support. Would you be interested in sending through a patch?

[moriwaka]

Yes, I'll try to make a patch.