Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

pmrep is using BrokenPipeError which is not available in Python 2 #82

Closed
happz opened this Issue Mar 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

happz commented Mar 18, 2016

Test case 880 failed for me with the following traceback:

--- /var/lib/pcp/testsuite/880.out 2016-03-16 08:18:27.000000000 -0400
+++ /var/lib/pcp/testsuite/880.out.bad 2016-03-16 10:32:05.774197932 -0400
@@ -1,2 +1,14 @@
QA output created by 880
expect no broken pipe exceptions or Exception Ignored errors
+Traceback (most recent call last):

  • File "/usr/bin/pmrep", line 1371, in
  • P.finalize()
  • File "/usr/bin/pmrep", line 1351, in finalize
  • except BrokenPipeError:
    +NameError: global name 'BrokenPipeError' is not defined
    +Traceback (most recent call last):
  • File "/usr/bin/pmrep", line 1371, in
  • P.finalize()
  • File "/usr/bin/pmrep", line 1351, in finalize
  • except BrokenPipeError:
    +NameError: global name 'BrokenPipeError' is not defined

BrokenPipeError was added in Python 3.3, and this was ran with Python 2.7. I guess catching IOError and checking whether its errno == errno.EPIPE might work for Python 2.

@happz happz changed the title from pmrep is using BrokenPipeError to pmrep is using BrokenPipeError which is not available in Python 2 Mar 18, 2016

Contributor

natoscott commented Mar 21, 2016

Marko's fix for this is in the master branch now.

@natoscott natoscott closed this Mar 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment