Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
[python-pcp] Fix a bug in pmsubsys which causes timestamp to reset. #31
Conversation
pcpemail
commented
Jul 16, 2015
|
Hi Marc, marcliangma8 notifications@github.com writes:
Thanks for posting this. The patch looks sound to me, and fixes the issue Cheers, Lukas |
|
This fix was merged awhile back, not sure why its still showing as open. |
marcliangma8 commentedJul 16, 2015
Problem:
pmFreeResult is used to free memory allocated by metric_result. However, it will corrupt memory and reset self._timestamp for diff calculation. So, all subsequent collections will have huge aggregated values instead of rate between intervals.
Fix:
Use copy.deepcopy to assign values for _timestamp which will survive from pmFreeResult call.