Fixes SIGSEGV, 64-bit format specifiers, dlsym bug and IPC on Windows

configure

@@ -11317,13 +11317,21 @@ $2 == "bozo"	{ t = $1
 	_fmt='"ld"'
 	;;
     'long long'|'long long int')
-	_fmt='"lld"'
+        if test $target_os = mingw; then
+            _fmt='"I64d"'
+        else
+	    _fmt='"lld"'
+        fi
 	;;
     'unsigned long'|'unsigned long int'|'long unsigned int')
 	_fmt='"lu"'
 	;;
     'unsigned long long')
-	_fmt='"llu"'
+        if test $target_os = mingw; then
+            _fmt='"I64u"'
+        else
+	    _fmt='"llu"'
+        fi
 	;;
     *\*)	# pointer to a something
 	_fmt='"p"'

configure.ac

@@ -1821,13 +1821,21 @@ $2 == "bozo"	{ t = $1
 	_fmt='"ld"'
 	;;
     'long long'|'long long int')
-	_fmt='"lld"'
+        if test $target_os = mingw; then
+            _fmt='"I64d"'
+        else
+	    _fmt='"lld"'
+        fi
 	;;
     'unsigned long'|'unsigned long int'|'long unsigned int')
 	_fmt='"lu"'
 	;;
     'unsigned long long')
-	_fmt='"llu"'
+        if test $target_os = mingw; then
+            _fmt='"I64u"'
+        else
+	    _fmt='"llu"'
+        fi
 	;;
     *\*)	# pointer to a something
 	_fmt='"p"'

src/include/pcp/config.h.in

@@ -570,12 +570,6 @@ extern const char *wsastrerror(int);
 #define SIGHUP		(NSIG+1)
 #define SIGUSR1		(NSIG+2)
 #define SIGBUS		(NSIG+3)
-#define S_IRGRP		0
-#define S_IWGRP		0
-#define S_IROTH		0
-#define S_IWOTH		0
-#define S_IRWXG		0
-#define S_IRWXO		0
 #define S_ISVTX		0
 
 #define fcntl(f, cmd, ...) 0

src/libpcp/src/auxserver.c

@@ -630,6 +630,7 @@ OpenRequestPorts(__pmFdSet *fdset, int backlog)
 	}
     }
 
+#ifndef IS_MINGW
     /* Open a local unix domain socket, if specified, and supported. */
     if (localSocketPath != NULL) {
 #if defined(HAVE_STRUCT_SOCKADDR_UN)
@@ -644,6 +645,7 @@ OpenRequestPorts(__pmFdSet *fdset, int backlog)
 		      pmProgname);
 #endif
     }
+#endif
 
     if (success)
 	return maximum;

src/libpcp/src/win32.c

@@ -89,7 +89,7 @@ __pmSetSignalHandler(int sig, __pmSignalHandler func)
     char *signame, evname[64];
     HANDLE eventhdl, waithdl;
 
-    if ((signame = MapSignals(sig, &index)) < 0)
+    if ((signame = MapSignals(sig, &index)) == NULL)
 	return index;
 
     if (signals[index].callback) {	/* remove old handler */

src/pmcd/src/config.c

@@ -1995,8 +1995,8 @@ GetAgentDso(AgentInfo *aPtr)
 #if defined(HAVE_DLOPEN)
     dlerror();
     dso->initFn = (void (*)(pmdaInterface*))dlsym(dso->dlHandle, dso->entryPoint);
-    dlerrstr = dlerror();
-    if (dlerrstr != NULL) {
+    if (dso->initFn == NULL) {
+        dlerrstr = dlerror();
 	fprintf(stderr, "Couldn't find init function `%s' in %s DSO: %s\n",
 		     dso->entryPoint, aPtr->pmDomainLabel, dlerrstr);
 	dlclose(dso->dlHandle);