/pcp

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Windows: Fix Performance Counter for mem.cache.bytes #43

Merged
merged 1 commit into from Aug 24, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dgiagio @natoscott
@dgiagio
Contributor

dgiagio commented Aug 21, 2015

The mem.cache.bytes metric is collecting data from an incorrect Performance Counter: \Memory\Pages Faults/sec. This patch fixes that by pointing to \Memory\Cache Bytes. Also fixed the data types (U32 -> U64) and semantic interpretation (COUNTER -> INSTANT). For consistency, changed \Metric\Cache Bytes Peak data type (64 -> U64) as well.

@natoscott natoscott merged commit 387d1e7 into performancecopilot:master Aug 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment