first wave of diffs to compile on OpenBSD

[jirib]

It passed configure, gmake compiles but it still fails later on linking...

...
gcc -L/usr/local/lib -L/usr/X11R6/lib -L/usr/local/lib -L/usr/X11R6/lib -Wall -L./src/libpcp/src -L./src/libpcp_pmda/src  -L/usr/local/lib -L/usr/X11R6/lib -Wall -L../src/libpcp/src -L../src/libpcp_pmda/src  -L/usr/local/lib -L/usr/X11R6/lib -Wall -L../../src/libpcp/src -L../../src/libpcp_pmda/src  -L/usr/local/lib -L/usr/X11R6/lib -Wall -L../../../src/libpcp/src -L../../../src/libpcp_pmda/src  -Wl,--version-script=exports -o libpcp..3  connect.o context.o desc.o err.o fetch.o fetchgroup.o freeresult.o help.o instance.o p_desc.o p_error.o p_fetch.o p_instance.o p_profile.o p_result.o p_text.o p_pmns.o p_creds.o p_attr.o pdu.o pdubuf.o pmns.o profile.o store.o units.o util.o ipc.o sortinst.o logmeta.o logportmap.o logutil.o tz.o interp.o checksum.o rtime.o tv.o spec.o fetchlocal.o optfetch.o AF.o stuffvalue.o endian.o config.o auxconnect.o auxserver.o discovery.o p_lcontrol.o p_lrequest.o p_lstatus.o logconnect.o logcontrol.o connectlocal.o derive.o derive_fetch.o events.o lock.o hash.o fault.o access.o getopt.o probe.o avahi.o accounts.o    getdate.tab.o -lavahi-common -lavahi-client -lm -lpthread      
instance.o: In function `inresult_to_lists':
/home/jirib/tmp/moje/pcp/src/libpcp/src/instance.c:200: warning: warning: strcpy() is almost always misused, please use strlcpy()
/usr/local/lib/libavahi-common.so.0.0: warning: warning: rand() may return deterministic values, is that what you want?
pmns.o: In function `attach':
/home/jirib/tmp/moje/pcp/src/libpcp/src/pmns.c:651: warning: warning: strcat() is almost always misused, please use strlcat()
logportmap.o: In function `__pmLogFindPort':
/home/jirib/tmp/moje/pcp/src/libpcp/src/logportmap.c:403: warning: warning: sprintf() is often misused, please use snprintf()
/usr/local/lib/libdbus-1.so.11.1: warning: warning: vsprintf() is often misused, please use vsnprintf()
/usr/lib/crt0.o: In function `_start':
(.text+0x9d): undefined reference to `main'
collect2: ld returned 1 exit status
../../../src/include/buildrules:86: recipe for target 'libpcp..3' failed
gmake[3]: *** [libpcp..3] Error 1
GNUmakefile:24: recipe for target 'default' failed
gmake[2]: *** [default] Error 2
GNUmakefile:117: recipe for target 'default_pcp' failed
gmake[1]: *** [default_pcp] Error 2
gmake[1]: Leaving directory '/home/jirib/tmp/moje/pcp/src'
GNUmakefile:49: recipe for target 'default_pcp' failed
gmake: *** [default_pcp] Error 2

[kmcdonell]

Welcome, and thanks for helping to add OpenBSD to the list of supported platforms.

Would it be possible to resubmit this patch without all the white space changes? The diff is really hard to read because it is dominated by changes that strip white space from the ends of source lines ... I'd like to focus on the other changes ... 8^)

[natoscott]

| (.text+0x9d): undefined reference to `main'
| collect2: ld returned 1 exit status
| ../../../src/include/buildrules:86: recipe for target 'libpcp..3' failed

Looks like an update to src/include/builddefs.in is needed to add the openbsd magic for building libraries - see "netbsd" examples there (all references to TARGET_OS).

cheers.

[jirib]

I'll do new pull request with recommended changes.