Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change the blank length of pmiostat's output #87

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

wuliming commented Apr 29, 2016

No description provided.

Contributor

lberk commented May 3, 2016

Hi, is there a particular reason for this output change?

The change also breaks qa 842 and 1099 (easy fix as it's simply whitespace), but it would be great to have a commit with those changes as well if there's a reason to update the blank length.

fix the output samples issue
for need two fetches to report rate converted counter
metrics. so the actual output samples will be less than
the speicified number when using '-s' and '-T' option.
'+1' can fix this issue.

@wuliming wuliming closed this May 5, 2016

@wuliming wuliming reopened this May 5, 2016

Contributor

goodwinos commented May 5, 2016

the timestamp printed with the -x t option is 24 characters. So how come you want to change it to 28?

Contributor

wuliming commented May 5, 2016

Hi :

I think the blank is too little(just one blank as follow) between first column and second column.

Timestamp Device rrqm/s wrqm/s r/s w/s rkB/s wkB/s avgrq-sz avgqu-sz await r_await w_await %util

Thu May 5 01:33:38 2016 sda 0.0 0.0 0.0 2.0 0.0 4.0 2.00 0.00 2.5 0.0 2.5 0.5

the timestamp printed with the -x t option is 24 characters. So how come you want to change it to 28?


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHubhttps://github.com/performancecopilot/pcp/pull/87#issuecomment-217073537

Contributor

goodwinos commented May 5, 2016

On 05/05/2016 03:35 PM, wulm wrote:

Hi :

I think the blank is too little(just one blank as follow) between first column and second column.

Timestamp Device rrqm/s wrqm/s r/s w/s rkB/s wkB/s avgrq-sz avgqu-sz await r_await w_await %util

Thu May 5 01:33:38 2016 sda 0.0 0.0 0.0 2.0 0.0 4.0 2.00 0.00 2.5 0.0 2.5 0.5

well, the timestamp lines up with the timestamp column header, and the device name (sda in your example)
lines up with the 'Device' column header .. and space is rather precious in this report.

the timestamp printed with the -x t option is 24 characters. So how come you want to change it to 28?


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHubhttps://github.com/performancecopilot/pcp/pull/87#issuecomment-217073537


You are receiving this because you commented.
Reply to this email directly or view it on GitHub #87 (comment)

Contributor

lberk commented May 24, 2016

Closing due to inactivity, perhaps the spacing could be an argument to be specified/passed in the event there are alternate personal preferences.

@lberk lberk closed this May 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment