Permalink
Browse files

metrics: fix lint errors

  • Loading branch information...
1 parent 38f2520 commit 39b9fa67c8fb8361ae06832bdec94adfe41b4e41 @suyash suyash committed Aug 12, 2016
Showing with 28 additions and 7 deletions.
  1. +28 −7 metrics.go
View
@@ -1165,28 +1165,45 @@ func (h *PCPHistogram) Min() int64 {
return int64(h.vals["min"].val.(float64))
}
-func (h *PCPHistogram) update() {
+func (h *PCPHistogram) update() error {
if val := float64(h.h.Min()); h.vals["min"].val != val {
- h.setInstance(val, "min")
+ err := h.setInstance(val, "min")
+ if err != nil {
+ return err
+ }
}
if val := float64(h.h.Max()); h.vals["max"].val != val {
- h.setInstance(val, "max")
+ err := h.setInstance(val, "max")
+ if err != nil {
+ return err
+ }
}
if val := h.h.Mean(); h.vals["mean"].val != val {
- h.setInstance(val, "mean")
+ err := h.setInstance(val, "mean")
+ if err != nil {
+ return err
+ }
}
stddev := h.h.StdDev()
if val := stddev * stddev; h.vals["variance"].val != val {
- h.setInstance(val, "variance")
+ err := h.setInstance(val, "variance")
+ if err != nil {
+ return err
+ }
}
if h.vals["standard_deviation"].val != stddev {
- h.setInstance(stddev, "standard_deviation")
+ err := h.setInstance(stddev, "standard_deviation")
+ if err != nil {
+ return err
+ }
}
+
+ return nil
}
// Record records a new value
@@ -1199,7 +1216,11 @@ func (h *PCPHistogram) Record(val int64) error {
return err
}
- h.update()
+ err = h.update()
+ if err != nil {
+ return err
+ }
+
return nil
}

0 comments on commit 39b9fa6

Please sign in to comment.