mmvdump: remove StringVal

mmvdump/cmd/mmvdump/main.go

@@ -81,7 +81,11 @@ func printValue(offset uint64) {
 	if m.Typ != mmvdump.StringType {
 		a, err = mmvdump.FixedVal(v.Val, m.Typ)
 	} else {
-		a, err = mmvdump.StringVal(v.Val, strings)
+		v, ok := strings[uint64(v.Extra)]
+		if !ok {
+			panic("invalid string address")
+		}
+		a = string(v.Payload[:])
 	}
 
 	if m.Indom != mmvdump.NoIndom {

mmvdump/mmvdump.go

@@ -226,13 +226,3 @@ func FixedVal(data uint64, t Type) (interface{}, error) {
 
 	return nil, errors.New("invalid type")
 }
-
-// StringVal will infer the string corresponding to an address
-func StringVal(data uint64, strings map[uint64]*String) (string, error) {
-	str, ok := strings[data]
-	if !ok {
-		return "", errors.New("invalid string address")
-	}
-
-	return string(str.Payload[:]), nil
-}