Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

rename Writer to Client #15

Closed
suyash opened this Issue Jul 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
Collaborator

suyash commented Jul 18, 2016

The fundamental reason for doing this is that the name writer in the golang community implies to most that the type implements io.Writer, and initially it did, but later on all the writing capability was abstracted away into bytebuffer, and the Buffer type does implement io.Writer, but speed.Writer doesn't, and I don't think the name is apt anymore. Looking at the current definition of the interface, I think Client is a more appropriate name, and will probably create less confusion.

Contributor

natoscott commented Jul 19, 2016

@suyash the suggested change certainly makes sense to me, go for it.

@suyash suyash closed this in 23aa3e6 Jul 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment