/speed

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add mmv version 2 support #24

Merged
merged 22 commits into from Aug 6, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@suyash @coveralls
@suyash
Collaborator

suyash commented Aug 5, 2016 • edited

  • add support to speed
  • add support to mmvdump
  • verify pcp qas for mmvdump
  • add tests to speed
  • add an example

suyash added some commits Aug 5, 2016

@suyash
metrics: make name pcpString to support v2 names
3cbeb65
@suyash
registry: track whether we need to write mmv version 2 
this adds a boolean flag to track currently registered string lengths
and if we get one not compatible with mmv version 1, we add all previous
metric names for version 2 and set it to true
34ec763
@suyash
client: initialize mmv v2 metric name offsets and write them when needed

All checks have failed

3 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-1.3%) to 81.96%
Details
1077279
@coveralls

coveralls commented Aug 5, 2016 • edited

Coverage Status

Coverage decreased (-1.3%) to 81.96% when pulling 1077279 on mmv2 into f7de99f on master.
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-0.8%) to 82.451% when pulling f18923c on mmv2 into f7de99f on master.
@suyash
registry: refactor AddMetric

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-0.8%) to 82.451%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
c77d334
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-0.8%) to 82.451% when pulling c77d334 on mmv2 into f7de99f on master.
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-0.8%) to 82.451% when pulling 8189196 on mmv2 into f7de99f on master.
@suyash
mmvdump: refactor

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-0.8%) to 82.451%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
6a584f0
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-0.8%) to 82.451% when pulling 6a584f0 on mmv2 into fac92ce on master.

suyash added some commits Aug 6, 2016

@suyash
instance: make name pcpString to support mmv2
1c276a6
@suyash
instance domain: add Instances() to the definition
67414d9
@suyash
registry: track instance name lengths
2bdf215
@suyash
client: initialize and write instance name offsets
71cc227
@suyash
client: fix matchInstance in tests
05757bd
@suyash
pcp: remove String() as pcpString is internal

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-1.1%) to 82.179%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
f09dc27
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-1.1%) to 82.179% when pulling f09dc27 on mmv2 into fac92ce on master.
@suyash
client: fix Metric and Instance Lengths

All checks have failed

2 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
6409525
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-1.3%) to 81.99% when pulling 990f035 on mmv2 into fac92ce on master.
@suyash
client: fix test

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-1.3%) to 81.99%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
49c6eaf
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-1.3%) to 81.99% when pulling 49c6eaf on mmv2 into fac92ce on master.

suyash added some commits Aug 6, 2016

@suyash
mmvdump: add mmv 2 support
f8410c9
@suyash
client: add testing support for mmv2 metrics and instances

All checks have failed

3 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-1.3%) to 81.99%
Details
5d7d6f5
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-1.3%) to 81.99% when pulling 5d7d6f5 on mmv2 into fac92ce on master.
@suyash
mmvdump: refactor main in cli

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 81.99%
Details
752f916
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage decreased (-1.3%) to 81.99% when pulling 752f916 on mmv2 into fac92ce on master.

suyash added some commits Aug 6, 2016

@suyash
registry: allow _ in names
1eb1e3e
@suyash
client: test mmv2 instances and metrics
a932618
@suyash
examples: singleton_string: use a longer metric name

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+3.0%) to 84.975%
Details
cfa72b1
@coveralls

coveralls commented Aug 6, 2016 • edited

Coverage Status

Coverage increased (+1.7%) to 84.975% when pulling cfa72b1 on mmv2 into fac92ce on master.

@suyash suyash merged commit b6f56db into master Aug 6, 2016
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+3.0%) to 84.975%
Details

@suyash suyash deleted the mmv2 branch Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment