New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Debian patches upstream when possible #46

Closed
tonin opened this Issue Dec 18, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@tonin
Member

tonin commented Dec 18, 2017

I think we can easily port upstream some Debian packages patches so that we simplify the whole packaging. These should probably be considered for inclusion in upstream:

The other patches should be reviewed too and added if possible.

@tonin tonin added this to the sprint-20180226 milestone Feb 19, 2018

@tonin

This comment has been minimized.

Member

tonin commented Feb 19, 2018

@vvidic Can you also have a look at merging the ntp-config.diff patch upstream by testing the existence of the step-tickers file?

@vvidic

This comment has been minimized.

Contributor

vvidic commented Feb 27, 2018

I don't think step-tickers file is used on the Debian side so I guest there should be no harm if we add it. Will check once more and create a PR.

@vvidic

This comment has been minimized.

Contributor

vvidic commented Mar 5, 2018

The problem was nonexisting directory /etc/ntp on the Debian side. I've added this directory to perfsonar-toolkit-ntp so writing step-tickers works now and ntp-config.diff patch is removed.

@tonin

This comment has been minimized.

Member

tonin commented Mar 5, 2018

Thanks! Can we also then remove https://github.com/perfsonar/toolkit/blob/debian/jessie/debian/patches/debian-ntp.diff I'm not sure what's intended with the different -e -a -s flags.

@vvidic

This comment has been minimized.

Contributor

vvidic commented Mar 12, 2018

You are right, /etc/ntp exist now so the configure_ntpd should also work without patching. Dropping this patch too.

@tonin

This comment has been minimized.

Member

tonin commented Mar 29, 2018

I think this is all we can port upstream at the moment.

@tonin tonin closed this Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment