New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debian packaging to latest dependency changes #49

Closed
tonin opened this Issue Feb 22, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@tonin
Member

tonin commented Feb 22, 2018

There has been quite a lot of perl library dependency changes following the addition of the psconfig libraries and the replacement of the LWP modules by the Mojo ones. We need to review that in the Debian packages too.

@tonin tonin added the debian label Feb 22, 2018

@vvidic

This comment has been minimized.

Contributor

vvidic commented Feb 22, 2018

Quite strange, can't get some test to run properly:

#   Failed test at t/client-psconfig-addressclasses.t line 346.
#          got: '10'
#     expected: '0'
# Looks like you failed 1 test of 523.
t/client-psconfig-addressclasses.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/523 subtests 
t/client-psconfig-circuits.t ........ ok
t/client-psconfig-contexts.t ........ ok
t/client-psconfig-disjoint.t ........ ok

#   Failed test at t/client-psconfig-labels.t line 219.
#          got: '2'
#     expected: '0'
# Looks like you failed 1 test of 369.
t/client-psconfig-labels.t .......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/369 subtests 
t/client-psconfig-list.t ............ ok

#   Failed test at t/client-psconfig-mesh.t line 84.
#          got: '1'
#     expected: '0'
# Looks like you failed 1 test of 60.
t/client-psconfig-mesh.t ............ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/60 subtests 

#   Failed test at t/client-psconfig-noagent.t line 123.
#          got: '1'
#     expected: '0'
# Looks like you failed 1 test of 53.
t/client-psconfig-noagent.t ......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/53 subtests 

#   Failed test at t/client-psconfig-taskgenerator.t line 181.
#          got: 'Q5N6OaenL2+IPB9WVK+PQw'
#     expected: 'UwWSmNRYrKPw0UKuTMXGbg'

#   Failed test at t/client-psconfig-taskgenerator.t line 197.
#          got: 'QBNMDnJZOfxP3ei9ZpFrcg'
#     expected: 'qWC5b7x0212uHxD1z5LTtg'
# Looks like you failed 2 tests of 70.
t/client-psconfig-taskgenerator.t ... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/70 subtests 
Can't use an undefined value as a HASH reference at t/client-psconfig-template.t line 198.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 34.
t/client-psconfig-template.t ........ 
Dubious, test returned 2 (wstat 512, 0x200)
All 34 subtests passed 

#   Failed test at t/client-psconfig.t line 597.
#          got: '2'
#     expected: '0'
# {}
# Looks like you failed 1 test of 538.
t/client-psconfig.t ................. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/538 subtests 

Perhaps @arlake228 has an idea what could be wrong here?

@arlake228

This comment has been minimized.

Contributor

arlake228 commented Feb 22, 2018

It looks like all of them except for the ones in client-psconfig-taskgenerator are because JSON is not validating against the JSON schema. Might want to check you have the perl module JSON::Validator installed. I don't have easy access to a debian host at the moment to test, but doing a dump of the result of the call to validate should tell what it doesn't like.

For task-generator, it doesn't like the checksum of the JSON produced. Again a dump of the $psched_task object should help show if there is something in the JSON or missing from the JSON that shouldn't be.

@vvidic

This comment has been minimized.

Contributor

vvidic commented Feb 22, 2018

@vvidic

This comment has been minimized.

Contributor

vvidic commented Feb 27, 2018

Ok, JSON::Validator needed a newer version of Test::Simple to run tests without errors and perl-shared needed a jq. The tests are passing now so I will update the deps.

@vvidic

This comment has been minimized.

Contributor

vvidic commented Mar 5, 2018

Mojo added to perl-shared, will check the Jenkins build.

@vvidic

This comment has been minimized.

Contributor

vvidic commented Mar 12, 2018

Jenkins looks good so closing this now.

@vvidic vvidic closed this Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment