Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service status check should use service API #79

Open
tonin opened this issue May 10, 2019 · 0 comments

Comments

Projects
None yet
3 participants
@tonin
Copy link
Member

commented May 10, 2019

The toolkit homepage Services list display the status of each service. This is coming from the /toolkit/services/host.cgi?method=get_services call. The internal of this CGI is handled by the check_running sub of NPToolkit/Services/Base.pm which is looking at the list of running processes by names or by PID coming from the OS starting scripts.

This way of doing is not very robust (process names used are very broad, i.e. python, and PID files might be unreadable by the CGI) nor very accurate (a process might be running, but the corresponding service can still be down or failing in some way).

We could improve that by doing proper service calls to check that the listed service is actually running and ready to serve. pScheduler has a dedicated /status API endpoint dedicated to that. Some of the other services checked probably have too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.