New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need both perfSONAR and Toolkit package version? #290

Closed
tonin opened this Issue Dec 21, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@tonin
Member

tonin commented Dec 21, 2017

In the toolkit web GUI, in the Host Details popup, we list the perfSONAR version and the Toolkit package version. In the JS code those are referenced as toolkit_version and rpm_version respectively. In the corresponding perl code these are toolkit_version and toolkit_rpm_version respectively. This is confusing.

Most, if not all, of the time, the 2 versions are the same.

Both values are also registered to the Lookup Service.

  • toolkit_version is declared in perfSONAR_PS/NPToolkit/Config/Version.pm and is coming out of the file /var/lib/perfsonar/bundles/bundle_version which is created by the corresponding bundle package installed
  • toolkit_rpm_version is declared in perfSONAR_PS/NPToolkit/Services/Base.pm and is coming from the RPM database information for CentOS hosts and from the dpkg/apt database information for Debian.

I think this should be refactored. Do we actually need both? Wouldn't the second one just be enough and actually more accurate?

@arlake228 arlake228 self-assigned this Jan 8, 2018

@arlake228 arlake228 added this to the sprint-20180423 milestone Apr 6, 2018

arlake228 added a commit to perfsonar/perl-shared that referenced this issue May 15, 2018

@arlake228 arlake228 closed this in 17ecc1e May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment