New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on #151 #243

Merged
merged 1 commit into from Jul 27, 2018

Conversation

Projects
None yet
2 participants
@Mte90
Copy link
Contributor

Mte90 commented Jul 7, 2018

Right now show the domain in the list but not in the pages.
I am not sure about how to pass the domain on https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L186

@@ -55,7 +55,7 @@
</a>
</td>
<td>
{% set addr = result.meta.url %}
{% set addr = result.meta('SERVER.SERVER_NAME') ~ result.meta.url %}

This comment has been minimized.

@markstory

markstory Jul 26, 2018

Member

Won't this be the server that xhgui is running on? That isn't necessarily the same server/host that the profile data was collected from.

This comment has been minimized.

@Mte90

Mte90 Jul 26, 2018

Contributor

As I saw show the right domain and not the server one.

This comment has been minimized.

@markstory

markstory Jul 27, 2018

Member

You're right. I misread the code earlier.

@markstory markstory merged commit 98406e3 into perftools:master Jul 27, 2018

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@Mte90

This comment has been minimized.

Copy link
Contributor

Mte90 commented Jul 27, 2018

@markstory about how to pass the domain on https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L186 to improve also the single view of the profile running do you have any hints

@markstory

This comment has been minimized.

Copy link
Member

markstory commented Jul 27, 2018

Wouldn't the profile have the host name in its metadata again?

@Mte90

This comment has been minimized.

Copy link
Contributor

Mte90 commented Jul 28, 2018

As I saw there is the https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L186 that share only few specific info and I don't know how to pass also the server name so I can reuse that value also on the frontend to show the domain.

@markstory

This comment has been minimized.

Copy link
Member

markstory commented Jul 28, 2018

The first run item should have the meta key.

@Mte90

This comment has been minimized.

Copy link
Contributor

Mte90 commented Jul 28, 2018

AS I can see share https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L185 only requests and not other parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment