Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by methods #265

Merged
merged 10 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@Mte90
Copy link
Contributor

commented Apr 8, 2019

Start from #237 and rewritten to add a new support.
Now other match the exact method/function support regular expression like from Composer* so all the method/function that fit this expression are removed.

Looking at the code now to filter the data is required to /run/view?id=5cab781f51dc5f34fa735812&filter to add a filter parameter in the URL or this code will be not executed.

Mte90 added some commits Apr 8, 2019

@markstory
Copy link
Member

left a comment

It would be good to have some tests covering what this does.

Show resolved Hide resolved src/Xhgui/Profile.php Outdated
Show resolved Hide resolved src/Xhgui/Profile.php Outdated
Show resolved Hide resolved src/Xhgui/Profile.php Outdated
@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

For tests I have to prepare a dev environment but I will do them :-)

Mte90 added some commits Apr 9, 2019

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

Started working on tests but not yet finished, required a bit with issue on docker on my system.

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

3 new unit tests added :-)
Let me know if it is missing something!

@markstory markstory merged commit 022281a into perftools:master Apr 15, 2019

3 checks passed

Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.