New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactification #24

Merged
merged 34 commits into from Nov 10, 2015

Conversation

Projects
None yet
2 participants
@peric
Owner

peric commented May 10, 2015

No description provided.

Show outdated Hide outdated index.html
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="css/style.css" />
<script src="https://fb.me/react-0.13.2.js"></script>
<script src="https://fb.me/JSXTransformer-0.13.2.js"></script>

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

you wan't to have build process done locally and not running transformer on other people's machines ;)

@zigomir

zigomir May 10, 2015

Collaborator

you wan't to have build process done locally and not running transformer on other people's machines ;)

Show outdated Hide outdated index.html
<link rel="stylesheet" type="text/css" href="css/style.css" />
<script src="https://fb.me/react-0.13.2.js"></script>
<script src="https://fb.me/JSXTransformer-0.13.2.js"></script>
<script src="https://code.jquery.com/jquery-2.1.3.min.js"></script>

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

Not sure, but do you need jquery? I see you do. Since you have React now, I think we can solve problem without it...we'll talk :)

@zigomir

zigomir May 10, 2015

Collaborator

Not sure, but do you need jquery? I see you do. Since you have React now, I think we can solve problem without it...we'll talk :)

Show outdated Hide outdated js/app.js
@@ -0,0 +1,548 @@
var OUTPUT_MYSQL = 'MySQL',

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

This file can easily be split to few smaller files.

@zigomir

zigomir May 10, 2015

Collaborator

This file can easily be split to few smaller files.

Show outdated Hide outdated js/app.js
this.forceUpdate();
// TODO: do I need this? How forceUpdate does updates based on references?
// this.setState({type: data});

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

Use setState wherever you can. forceUpdate should be your last exit. setState will trigger re-render of component and this is usually what you want.

@zigomir

zigomir May 10, 2015

Collaborator

Use setState wherever you can. forceUpdate should be your last exit. setState will trigger re-render of component and this is usually what you want.

Show outdated Hide outdated js/app.js
longName={setting.longName}
checked={setting.checked}
onChange={self.toggleCheck}
disabled={setting.disabled} />

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

props for using lots of props 👍 :)

@zigomir

zigomir May 10, 2015

Collaborator

props for using lots of props 👍 :)

Show outdated Hide outdated js/app.js
<Column
key={index + column.name}
objectKey={key}
data={self.state.columns}

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

data is really generic name. I believe you can think of something more specific ;)

@zigomir

zigomir May 10, 2015

Collaborator

data is really generic name. I believe you can think of something more specific ;)

Show outdated Hide outdated js/app.js
</div>
);
}
});

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

Liking small components like Setting, OutputType and Column you did here 👍

@zigomir

zigomir May 10, 2015

Collaborator

Liking small components like Setting, OutputType and Column you did here 👍

Show outdated Hide outdated js/app.js
" PRIMARY KEY (`countryCode`,`languages`)\n" +
") ENGINE=MyISAM DEFAULT CHARSET=utf8;\n\n" +
"{2}\n" +
"{3}";

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

ohnoes, this hurts. We're gonna convert this project to ES6 so you can use template strings

@zigomir

zigomir May 10, 2015

Collaborator

ohnoes, this hurts. We're gonna convert this project to ES6 so you can use template strings

Show outdated Hide outdated js/main.js
this.select();
// TODO: copy to clipboard
// https://github.com/zeroclipboard/zeroclipboard

This comment has been minimized.

@zigomir

zigomir May 10, 2015

Collaborator

👍

@zigomir

zigomir May 10, 2015

Collaborator

👍

@peric

This comment has been minimized.

Show comment
Hide comment
@peric

peric May 10, 2015

Owner

@zigomir, thanks a lot for that useful review and commit!

Owner

peric commented May 10, 2015

@zigomir, thanks a lot for that useful review and commit!

@zigomir zigomir referenced this pull request Jul 16, 2015

Merged

Reactify tests #26

peric added a commit that referenced this pull request Nov 10, 2015

@peric peric merged commit 209b798 into master Nov 10, 2015

@peric peric deleted the reactify branch Nov 10, 2015

@zigomir

This comment has been minimized.

Show comment
Hide comment
@zigomir

zigomir Nov 10, 2015

Collaborator

hhh 👍

Collaborator

zigomir commented Nov 10, 2015

hhh 👍

@peric peric referenced this pull request Nov 10, 2015

Closed

Rewrite app in react.js #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment