New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`dist.ini` cleanup #12

merged 4 commits into from Jan 28, 2015


None yet
2 participants

paultcochrane commented Jan 4, 2015

This PR tidies up some minor issues with the dist.ini file. The most controversial of the changes is the change to the version regexp used to match the relevant release tag name; I might have implemented a regexp which is too specific and thus not flexible enough to handle possible future release tag names. If another regexp is more appropriate, please let me know and I'll update the PR accordingly.

As usual, any comments welcome!

paultcochrane added some commits Jan 4, 2015

Using version regexp to match current tag naming convention
It seems that the previous release tag naming convention was
qr/^release-(.+)$/, however this doesn't match what the current tag naming
convention (which is basically qr/^\d+\.\d+$/) and thus the Git::NextVersion
Dist::Zilla plugin was unable to find an appropriate version number and
hence the version number kept being set to 0.001 when running `dzil build`.
This change corrects this issue and the Git::NextVersion plugin determines
the version number correctly.
Changing Git::Tag tag_format to be consistent
This is to be consistent with the earlier release tag format change.

perigrin added a commit that referenced this pull request Jan 28, 2015

@perigrin perigrin merged commit bff4ab4 into perigrin:master Jan 28, 2015

@paultcochrane paultcochrane deleted the paultcochrane:pr/dist_ini_cleanup branch Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment