New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `cpanfile` #7

Merged
merged 2 commits into from Jan 28, 2015

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Jan 2, 2015

The file cpanfile is automatically generated by Dist::Zilla and hence doesn't need to be included in the revision control system. I'm not 100% sure about this change, since it could be that you had a good reason to include this file of which I'm not aware. My general guideline is that one doesn't need automatically generated files in the repo; hence my rationale for this PR. Also, running dzil test updates the cpanfile and thus creates changes which are locally relevant to the development environment but not relevant to be committed, so I'm fairly sure the file isn't needed in the repo. If I'm wrong, don't worry about disregarding this PR: it's submitted in the hope that it helps :-)

paultcochrane added some commits Jan 2, 2015

Ignoring `cpanfile`
This file is automatically generated and doesn't need to be tracked by the
version control system.
@perigrin

This comment has been minimized.

Show comment
Hide comment
@perigrin

perigrin Jan 28, 2015

Owner

I typically like to leave the cpanfile so that you can install the module from github, in this case that wouldn't be possible anyway because there is no minimal makefile ... so I'm merging this anyway.

Owner

perigrin commented Jan 28, 2015

I typically like to leave the cpanfile so that you can install the module from github, in this case that wouldn't be possible anyway because there is no minimal makefile ... so I'm merging this anyway.

perigrin added a commit that referenced this pull request Jan 28, 2015

@perigrin perigrin merged commit c500de5 into perigrin:master Jan 28, 2015

@paultcochrane paultcochrane deleted the paultcochrane:pr/remove_cpanfile branch Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment