New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for untested methods #8

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Jan 2, 2015

This PR adds tests for the methods which were not previously covered by the test suite. In the process of adding these tests, I believe I've found (and fixed) a bug in undeclare_prefix.

Each test starts with a fresh object, which doesn't follow the pattern of the existing tests, however I feel it is a good practice for each test to be as self-contained as possible and not dependent upon tests previously run. If this is undesired for this project, please let me know and I'll update the code and submit an updated PR.

Comments most certainly welcome. I hope this helps in some way :-)

paultcochrane added some commits Jan 2, 2015

Fixing bug in undeclare_prefix()
The recently added test for undeclare_prefix() showed that after having
undeclared a prefix, it still existed.  This change corrects this error; I'm
fairly sure it's correct that one wants to return from undeclare_prefix() if
the prefix value isn't defined, not *unless* it's not defined.
@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Jan 4, 2015

Contributor

Just as an aside: the fix for the undeclare_prefix bug should close RT#15923.

Contributor

paultcochrane commented Jan 4, 2015

Just as an aside: the fix for the undeclare_prefix bug should close RT#15923.

@perigrin

This comment has been minimized.

Show comment
Hide comment
@perigrin

perigrin Jun 29, 2017

Owner

merged as rebased commits

Owner

perigrin commented Jun 29, 2017

merged as rebased commits

@perigrin perigrin closed this Jun 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment