From 6f74a797c16dd1a06a0251fb95b0c76f9becb809 Mon Sep 17 00:00:00 2001 From: Rappie Date: Mon, 11 Mar 2024 20:40:21 +0100 Subject: [PATCH 1/3] Formatting --- src/MathHelper.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/MathHelper.sol b/src/MathHelper.sol index f8d3ec2..a210428 100644 --- a/src/MathHelper.sol +++ b/src/MathHelper.sol @@ -5,8 +5,8 @@ abstract contract MathHelper { function min(uint256 a, uint256 b) internal pure returns (uint256) { return a < b ? a : b; } - - // Forked from https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v5.0.0/contracts/utils/math/SignedMath.sol + + // Forked from https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v5.0.0/contracts/utils/math/SignedMath.sol function max(int256 a, int256 b) internal pure returns (int256) { return a > b ? a : b; } From 71103cc66c263610b7dd0ad3b9445afcc2778715 Mon Sep 17 00:00:00 2001 From: Rappie Date: Mon, 11 Mar 2024 20:40:53 +0100 Subject: [PATCH 2/3] Signed to unsigned `abs` and `diff` --- src/MathHelper.sol | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/MathHelper.sol b/src/MathHelper.sol index a210428..d43ba57 100644 --- a/src/MathHelper.sol +++ b/src/MathHelper.sol @@ -15,4 +15,12 @@ abstract contract MathHelper { function abs(int128 n) internal pure returns (int128) { return n >= 0 ? n : -n; } + + function abs(int256 n) internal pure returns (uint256) { + return n >= 0 ? uint256(n) : uint256(-n); + } + + function diff(int256 a, int256 b) internal pure returns (uint256) { + return a >= b ? uint256(a - b) : uint256(b - a); + } } From 74b4891de042dfe53473e6d723d8cfb3fd8492df Mon Sep 17 00:00:00 2001 From: Rappie Date: Mon, 11 Mar 2024 20:46:01 +0100 Subject: [PATCH 3/3] Add `diff` for uint to uint --- src/MathHelper.sol | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/MathHelper.sol b/src/MathHelper.sol index d43ba57..7de0dde 100644 --- a/src/MathHelper.sol +++ b/src/MathHelper.sol @@ -23,4 +23,8 @@ abstract contract MathHelper { function diff(int256 a, int256 b) internal pure returns (uint256) { return a >= b ? uint256(a - b) : uint256(b - a); } + + function diff(uint256 a, uint256 b) internal pure returns (uint256) { + return a >= b ? a - b : b - a; + } }