New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the files in binary mode to avoid mutating newlines. Fixes #44 #45

Merged
merged 1 commit into from Apr 21, 2014

Conversation

Projects
None yet
2 participants
@jaraco
Contributor

jaraco commented Apr 20, 2014

Consider this pull request which addresses issue #44 by saving files the same way they're opened.

peritus added a commit that referenced this pull request Apr 21, 2014

Merge pull request #45 from jaraco/issue-44
Save the files in binary mode to avoid mutating newlines. Fixes #44

@peritus peritus merged commit 3a96ba8 into peritus:master Apr 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@peritus

This comment has been minimized.

Show comment
Hide comment
@peritus

peritus Apr 21, 2014

Owner

Good catch! Thank you. Looks like I need to wrap that up in a release.

Owner

peritus commented Apr 21, 2014

Good catch! Thank you. Looks like I need to wrap that up in a release.

@peritus

This comment has been minimized.

Show comment
Hide comment
@peritus

peritus Apr 21, 2014

Owner

Reopening as a reminder to myself to write a regression test for this.

Owner

peritus commented Apr 21, 2014

Reopening as a reminder to myself to write a regression test for this.

@peritus peritus added the v0.5 label Jun 13, 2014

@peritus

This comment has been minimized.

Show comment
Hide comment
@peritus

peritus Jun 15, 2014

Owner

This will be part of the upcoming version 0.5 — which you can install by running

sudo pip install https://github.com/peritus/bumpversion/archive/master.zip#egg=bumpversion-dev

I'd appreciate any testing before the release.

Owner

peritus commented Jun 15, 2014

This will be part of the upcoming version 0.5 — which you can install by running

sudo pip install https://github.com/peritus/bumpversion/archive/master.zip#egg=bumpversion-dev

I'd appreciate any testing before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment