New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error #1227

Closed
invariant opened this Issue Oct 2, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@invariant

invariant commented Oct 2, 2018

Freshly downloaded as per installation instructions. My go version is go1.11.1 darwin/amd64. On running go run make.go I get the following error:

gopherjs for perkeep.org/app/publisher/js error: exit status 1, ../../../../../usr/local/Cellar/go/1.11.1/libexec/src/reflect/value.go:673:60: cannot use t (variable of type *rtype) as *funcType value in argument to funcLayout
../../../../../usr/local/Cellar/go/1.11.1/libexec/src/reflect/value.go:336:21: cannot use methodReceiver(op, v, int(v.flag) >> flagMethodShift) (value of type *rtype) as *funcType value in assignment
exit status 1
@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 2, 2018

Go 1.11.1 made a few changes to reflect package. It looks like GopherJS might need to be updated accordingly. I'll investigate this later today.

Edit: Follow gopherjs/gopherjs#862 for updates.

dmitshur commented Oct 2, 2018

Go 1.11.1 made a few changes to reflect package. It looks like GopherJS might need to be updated accordingly. I'll investigate this later today.

Edit: Follow gopherjs/gopherjs#862 for updates.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 4, 2018

The upstream issue gopherjs/gopherjs#862 has been resolved. As far as I know, perkeep vendors GopherJS, so it'll need to update to the latest version, and this build error should be resolved.

dmitshur commented Oct 4, 2018

The upstream issue gopherjs/gopherjs#862 has been resolved. As far as I know, perkeep vendors GopherJS, so it'll need to update to the latest version, and this build error should be resolved.

@mpl

This comment has been minimized.

Show comment
Hide comment
@mpl

mpl Oct 4, 2018

Contributor

@dmitshur Jsyk, we still indeed vendor things, but we also support Go modules now.

Anyway, I'll try to bump our gopherjs dep this week-end if nobody has gotten around to it before.

Contributor

mpl commented Oct 4, 2018

@dmitshur Jsyk, we still indeed vendor things, but we also support Go modules now.

Anyway, I'll try to bump our gopherjs dep this week-end if nobody has gotten around to it before.

@mpl

This comment has been minimized.

Show comment
Hide comment
Contributor

mpl commented Oct 7, 2018

@mpl

This comment has been minimized.

Show comment
Hide comment
@mpl

mpl Oct 7, 2018

Contributor

@dmitshur PTAL

Contributor

mpl commented Oct 7, 2018

@dmitshur PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment