Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove references to SPDY #1269

Merged
merged 2 commits into from Jul 10, 2019
Merged

Conversation

@zenhack
Copy link
Contributor

zenhack commented Jun 24, 2019

Which has been deprecated for some time now; the references to it really
date the documents.

@googlebot googlebot added the cla: yes label Jun 24, 2019
(e.g. SPDY). If your client and server don't support SPDY, you want
to use the batch stat and batch upload endpoints, which hopefully can
die when the future finishes arriving.
depends on whether or not you're using HTTP 2.0. If your client and

This comment has been minimized.

Copy link
@mpl

mpl Jun 30, 2019

Contributor
Suggested change
depends on whether or not you're using HTTP 2.0. If your client and
depends on whether or not you're using HTTP/2.0. If your client and

This comment has been minimized.

Copy link
@mpl

mpl Jul 1, 2019

Contributor

why did you mark it resolved?

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Jun 30, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 30, 2019
@zenhack zenhack force-pushed the zenhack:docs-remove-spdy-refs branch from b2396ea to efebc17 Jun 30, 2019
@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Jun 30, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 30, 2019
@zenhack

This comment has been minimized.

Copy link
Contributor Author

zenhack commented Jul 8, 2019

Which has been deprecated for some time now; the references to it really
date the documents.
@mpl

This comment has been minimized.

Copy link
Contributor

mpl commented Jul 9, 2019

Sorry for the slow reply; I was out in the woods all last week.

no problem, that's what woods are for.

IIRC, there was a button to auto-apply you suggested changes, and when I clicked it it also marked it as resolved. The CLA bot seems to have freaked out about the commit it generated (which had both of us as authors). It's a feature I've not seen before, perhaps it's new. I then noticed a couple other places where the same change needed to be made, and so did that locally and squashed, hence the force push. Sorry for the confusion.

Well, I don't know what went wrong in the whole process, but the reason I'm asking is that the current state of the PR is the opposite of what I was suggesting: we need "HTTP/2.0" everywhere, not "HTTP 2.0".

@zenhack zenhack force-pushed the zenhack:docs-remove-spdy-refs branch from efebc17 to b243f0f Jul 9, 2019
@zenhack

This comment has been minimized.

Copy link
Contributor Author

zenhack commented Jul 9, 2019

doc/protocol/blob-stat.md Outdated Show resolved Hide resolved
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Jul 9, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 9, 2019
@mpl

This comment has been minimized.

Copy link
Contributor

mpl commented Jul 10, 2019

I don't understand why the cla check is failing, but I'm going to assume we're all good since you already submitted CLs/PRs to the project in the past.

@mpl mpl merged commit 6db9cb8 into perkeep:master Jul 10, 2019
1 of 3 checks passed
1 of 3 checks passed
cla/google CLAs are signed, but unable to verify author consent
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.