New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle support #35

Merged
merged 4 commits into from Mar 31, 2012

Conversation

Projects
None yet
3 participants
@masaki
Contributor

masaki commented Jan 1, 2012

  • support carton bundle
    • download by cpanm --scandeps --format=dists --save-dists=local/cache
    • use Dist::Metadata and IO::Compress::Gzip for creating DarkPAN index
  • support carton install --cached using bundled DarkPAN
  • do not use CPAN::Meta::load_file when MYMETA.json is not exist

masaki added some commits Dec 31, 2011

merged from 'support-bundle'
commit c5346e8b54ce8ba51e435f0a4763ee9923166ee5
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sun Jan 1 03:30:28 2012 +0900

    support gzip

commit d98f183a5ad843c412c4d507ec7bbb400e144f53
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sun Jan 1 03:07:14 2012 +0900

    install --cached

commit bb83b459e881e9e519bf7f049a034d6743086956
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sun Jan 1 02:00:10 2012 +0900

    create bundle darkpan index

commit 2a19db9ffdeb76d01aa37601e8969204c422491e
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 17:58:58 2011 +0900

    rename

commit 00279d5c3996454138067a7400556832bea52ac5
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 17:07:10 2011 +0900

    comment

commit 77d85bc27f0d297914fe8309193616ee13cecbb2
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 16:31:35 2011 +0900

    inverse options

commit ef871ac74543be31842d73cbe7217c673f92e294
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 16:31:26 2011 +0900

    dependency

commit 1e7478e95ab82037155f493cb09228bddf76a454
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 15:35:30 2011 +0900

    refactor

commit 899c770ca073cbbafc3144ea7eac5d1872f9376f
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 14:46:32 2011 +0900

    comment

commit 23581ecf50362def5c0697e96162525cb2ee9024
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 14:44:52 2011 +0900

    lazy load

commit 925427fc6a42fe573c6cc53d2fc696eb051acb48
Author: NAKAGAWA Masaki <masaki.nakagawa@gmail.com>
Date:   Sat Dec 31 02:30:10 2011 +0900

    'carton bundle'
@Potatohead

This comment has been minimized.

Show comment
Hide comment
@Potatohead

Potatohead Feb 7, 2012

I was playing around with this patched version today and experienced problems when using 'carton install --path' after 'carton bundle'. I think the directory populated by bundle should exist outside of the carton path as I believe the intention is for it to be a committed resource like carton.lock rather than something associated with the local checkout.

Potatohead commented Feb 7, 2012

I was playing around with this patched version today and experienced problems when using 'carton install --path' after 'carton bundle'. I think the directory populated by bundle should exist outside of the carton path as I believe the intention is for it to be a committed resource like carton.lock rather than something associated with the local checkout.

miyagawa added a commit that referenced this pull request Mar 31, 2012

@miyagawa miyagawa merged commit 3627125 into perl-carton:master Mar 31, 2012

@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Mar 31, 2012

Contributor

This is awesome.

Contributor

miyagawa commented Mar 31, 2012

This is awesome.

@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Mar 31, 2012

Contributor

@Potatohead no, i don't think it's a good idea to commit bundled resources. This is useful when deploying these distributions to a bunch of machines in your network to avoid redownloading from CPAN mirrors on each machine (speed), and also to guarantee that it won't download from remote (trust).

Contributor

miyagawa commented Mar 31, 2012

@Potatohead no, i don't think it's a good idea to commit bundled resources. This is useful when deploying these distributions to a bunch of machines in your network to avoid redownloading from CPAN mirrors on each machine (speed), and also to guarantee that it won't download from remote (trust).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment