Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixes & new features for the next branch/version #4

Merged
merged 14 commits into from Jan 21, 2012

Conversation

Projects
None yet
1 participant
Contributor

marschap commented Oct 2, 2011

Hi Graham,

please consider pulling the following fixes into your next branch:

  • document Net::LDAP::Control::MatchedValues in Net::LDAP::Control
    POD addition only
  • add error string for LDAP_VLV_ERROR
    This unbreaks test 77 in t/06constant.t.
  • add Cancel extended operation (RFC 3909)
  • fix spelling of LDAP_CANCELED for consistency's sake
  • add constant for DontUseCopy control
  • update reference documents in POD
    POD changes to adjust to the fact that some drafts are now RFCs
  • base Net::LDAP::FilterList on Net::LDAP::Filter
    This is not yet 100% correct: Net::LDAP::Filter's _encode
    differ's from what we need by adding a dnAttributes key to the
    hash ref returned. This is not allowed for Net::LDAP::FilterList.
  • add MatchdValues control (RFC 3876)
    This comprises the packages
    • Net::LDAP::Control::MatchedValues
    • Net::LDAP::FilterList
      which are both contained in the file lib/Net/LDAP/Control/MatchedValues.pm
  • a bit of refactoring for Net::LDAP::Filter
    • make _encode resonsible for all simple filter items
    • remove unused variable
    • update comments
  • fixes for the ProxyAuthorization control
    • better documentation
      • mention RFC
      • tell the purpose of the control
    • fix name of the control: LDAP_CONTROL_PROXYAUTHORIZATION
      Keep the old, wrong name in N:L::Constant for compatibility reasons
  • document Net::LDAP::Control::Assertion in Net::LDAP::Control
    POD addition only
  • make sure to call the correct as_string()
    this fixes a border case in Net::LDAP::Control::Assertion

What about an update of perl-ldap?

With the critical bug in 0.43, which was fixed in the previous update of
your next branch, the doc updates and the new controls & extensions,
shouldn't this make a nice new 0.44?

Best
Peter

marschap added some commits Oct 1, 2011

@marschap marschap make sure to call the correct as_string()
As $f is not an object, calling $f->as_string fails.
Tell Perl where to find the as_string we want.

While I'm at it, make some minor changes to the documentation.
47f3b90
@marschap marschap document Net::LDAP::Control::Assertion in Net::LDAP::Control 2bf82c7
@marschap marschap fixes for the ProxyAuthorization control
* better documentation
  - mention RFC
  - tell the purpose of the control
* fix name of the control:  LDAP_CONTROL_PROXYAUTHORIZATION
  Keep the old, wrong name in N:L::Constant for compatibility reasons
be54ef1
@marschap marschap a bit of refactoring for Net::LDAP::Filter
* make _encode resonsible for all simple filter items
* remove unused variable
* update comments
3d50277
@marschap marschap add MatchdValues control (RFC 3876)
This comprises the packages
* Net::LDAP::Control::MatchedValues
* Net::LDAP::FilterList
which are both contained in the file lib/Net/LDAP/Control/MatchedValues.pm
2416d1b
@marschap marschap base Net::LDAP::FilterList on Net::LDAP::Filter
This is not yet 100% correct: Net::LDAP::Filter's _encode
differ's from what we need by adding a dnAttributes key to the
hash ref returned.  This is not allowed for Net::LDAP::FilterList.
063612e
@marschap marschap update reference documents in POD 295e523
@marschap marschap add constant for DontUseCopy control f45f2cd
@marschap marschap fix spelling of LDAP_CANCELED for consistency's sake e0a5f40
@marschap marschap add Cancel extended operation (RFC 3909) 5d48528
@marschap marschap add error string for LDAP_VLV_ERROR
This fixes/unbreaks test 77 in t/06constant.t.
66b8814
@marschap marschap document Net::LDAP::Control::MatchedValues in Net::LDAP::Control ff74e0f
@marschap marschap Makefile.PL: update resource info on repository 84e9247
@marschap marschap MANIFEST.SKIP: sync with Perl 5.14.2's ExtUtils version
This leads to .gitignore and MYMETA.yml being ignored.
4fb95de

@marschap marschap added a commit that referenced this pull request Jan 21, 2012

@marschap marschap Merge pull request #4 from marschap/next
fixes & new features for the next branch/version
7d26571

@marschap marschap merged commit 7d26571 into perl-ldap:next Jan 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment