From ba0a8031b0ca592ceec980e12e3c6380976739bf Mon Sep 17 00:00:00 2001 From: Wesley Schwengle Date: Mon, 8 Aug 2022 20:57:09 -0400 Subject: [PATCH] Fix author tests with dzil Add a perlcriticrc file which treats `use Moose` as `use strict; use warnings`. Add trusted POD for BUILD methods of Moose. These do not need to be documented as they are part of the Moose API: https://metacpan.org/dist/Moose/view/lib/Moose/Manual/Construction.pod#BUILD Signed-off-by: Wesley Schwengle --- .perlcriticrc | 6 ++++++ lib/Net/SAML2/Binding/Redirect.pm | 4 ++++ lib/Net/SAML2/Protocol/ArtifactResolve.pm | 2 +- lib/Net/SAML2/Protocol/LogoutRequest.pm | 3 +-- lib/Net/SAML2/Types.pm | 3 ++- 5 files changed, 14 insertions(+), 4 deletions(-) create mode 100644 .perlcriticrc diff --git a/.perlcriticrc b/.perlcriticrc new file mode 100644 index 00000000..cef9af1d --- /dev/null +++ b/.perlcriticrc @@ -0,0 +1,6 @@ +[TestingAndDebugging::RequireUseStrict] +equivalent_modules = Moose Test::Net::SAML2 + +[TestingAndDebugging::RequireUseWarnings] +equivalent_modules = Moose Test::Net::SAML2 + diff --git a/lib/Net/SAML2/Binding/Redirect.pm b/lib/Net/SAML2/Binding/Redirect.pm index 172a5188..781ab721 100644 --- a/lib/Net/SAML2/Binding/Redirect.pm +++ b/lib/Net/SAML2/Binding/Redirect.pm @@ -129,6 +129,10 @@ has 'sls_double_encoded_response' => ( default => 0 ); +=for Pod::Coverage BUILD + +=cut + sub BUILD { my $self = shift; diff --git a/lib/Net/SAML2/Protocol/ArtifactResolve.pm b/lib/Net/SAML2/Protocol/ArtifactResolve.pm index 13f94851..49a83a8f 100644 --- a/lib/Net/SAML2/Protocol/ArtifactResolve.pm +++ b/lib/Net/SAML2/Protocol/ArtifactResolve.pm @@ -1,7 +1,7 @@ package Net::SAML2::Protocol::ArtifactResolve; +use Moose; # VERSION -use Moose; use MooseX::Types::URI qw/ Uri /; use URN::OASIS::SAML2 qw(:urn); diff --git a/lib/Net/SAML2/Protocol/LogoutRequest.pm b/lib/Net/SAML2/Protocol/LogoutRequest.pm index 9256e590..fa91e911 100644 --- a/lib/Net/SAML2/Protocol/LogoutRequest.pm +++ b/lib/Net/SAML2/Protocol/LogoutRequest.pm @@ -1,7 +1,6 @@ package Net::SAML2::Protocol::LogoutRequest; -# VERSION - use Moose; +# VERSION use MooseX::Types::Common::String qw/ NonEmptySimpleStr /; use MooseX::Types::URI qw/ Uri /; use Net::SAML2::XML::Util qw/ no_comments /; diff --git a/lib/Net/SAML2/Types.pm b/lib/Net/SAML2/Types.pm index 40f9f743..78f97d94 100644 --- a/lib/Net/SAML2/Types.pm +++ b/lib/Net/SAML2/Types.pm @@ -1,8 +1,9 @@ package Net::SAML2::Types; -# VERSION use warnings; use strict; +# VERSION + # ABSTRACT: Custom Moose types for Net::SAML2 use Types::Serialiser;