New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRC] Fix #21 : stop words with dots not correctly checked #27

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@pauloscustodio
Contributor

pauloscustodio commented Apr 15, 2016

Check for word abbreviations was not correct.
Add text t/fix_21.t to assert correction.

pauloscustodio added some commits Feb 27, 2016

Fix #21 : stop words with dots not correctly checked
Check for word abbreviations was not correct.
Added text t/fix_21.t to assert correction.
Solve Travis-CI error - line endings
Failed test 'No incorrect line endings in 't/fix_21.t' on line 11
at xt/author/eol.t line 24.
@dolmen

This comment has been minimized.

Show comment
Hide comment
@dolmen

dolmen Apr 19, 2016

Contributor

Please squash your commits into a single one

Contributor

dolmen commented Apr 19, 2016

Please squash your commits into a single one

@pauloscustodio pauloscustodio deleted the pauloscustodio:prc_fix21 branch Apr 19, 2016

@pauloscustodio

This comment has been minimized.

Show comment
Hide comment
@pauloscustodio

pauloscustodio Apr 19, 2016

Contributor

Done. I've created a new branch with only one commit and submitted a new
pull request.

Travis-CI rejects the commit.

  • lib/Pod/Wordlist.pm line 29 is a false positive; $text is referred in a
    POD documentation section
  • lib/Pod/Spell.pm line 133 is a false positive; $text is referred in line
    142.

[17:24:57] xt/release/unused-vars.t ......

  Failed test 'lib/Pod/Wordlist.pm'

  at xt/release/unused-vars.t line 12.

$text is used once in &Pod::Wordlist::learn_stopwords at

lib/Pod/Wordlist.pm line 29

[17:24:57] xt/release/unused-vars.t ...... 1/1

  Failed test 'lib/Pod/Spell.pm'

  at xt/release/unused-vars.t line 12.

$text is used once in &Pod::Spell::_Processor::command at

lib/Pod/Spell.pm line 133

Looks like you failed 2 tests of 2.

On Tue, Apr 19, 2016 at 5:39 PM, Olivier Mengué notifications@github.com
wrote:

Please squash your commits into a single one


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#27 (comment)

Contributor

pauloscustodio commented Apr 19, 2016

Done. I've created a new branch with only one commit and submitted a new
pull request.

Travis-CI rejects the commit.

  • lib/Pod/Wordlist.pm line 29 is a false positive; $text is referred in a
    POD documentation section
  • lib/Pod/Spell.pm line 133 is a false positive; $text is referred in line
    142.

[17:24:57] xt/release/unused-vars.t ......

  Failed test 'lib/Pod/Wordlist.pm'

  at xt/release/unused-vars.t line 12.

$text is used once in &Pod::Wordlist::learn_stopwords at

lib/Pod/Wordlist.pm line 29

[17:24:57] xt/release/unused-vars.t ...... 1/1

  Failed test 'lib/Pod/Spell.pm'

  at xt/release/unused-vars.t line 12.

$text is used once in &Pod::Spell::_Processor::command at

lib/Pod/Spell.pm line 133

Looks like you failed 2 tests of 2.

On Tue, Apr 19, 2016 at 5:39 PM, Olivier Mengué notifications@github.com
wrote:

Please squash your commits into a single one


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#27 (comment)

@dolmen

This comment has been minimized.

Show comment
Hide comment
@dolmen

dolmen Apr 25, 2016

Contributor

I've created a new branch with only one commit and submitted a new pull request.

The new one is #28.
Thanks!

Contributor

dolmen commented Apr 25, 2016

I've created a new branch with only one commit and submitted a new pull request.

The new one is #28.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment