Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #120

Merged
merged 2 commits into from Aug 9, 2020

Conversation

bmwiedemann
Copy link
Contributor

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Without this patch, the epics-base package varied in html docs
for every build.

This PR was done while working on reproducible builds for openSUSE.

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Without this patch, the epics-base package varied in html docs
for every build.

This PR was done while working on reproducible builds for openSUSE.
and drop one localtime call to be independent of timezones
@khwilliamson
Copy link
Contributor

Karen, this looks good to me, but I would like a more expert opinion.

@karenetheridge
Copy link
Member

looks good, but can we name the environment variable PERL_POD_SIMPLE_SOURCE_DATE_EPOCH to make it abundantly clear who the consumer of this variable is intended to be?

@bmwiedemann
Copy link
Contributor Author

Renaming the variable would be bad, because SOURCE_DATE_EPOCH is a standard name already consumed by dozens of other tools and to make this reproducible then would need packagers to discover and use this special variable.

@karenetheridge
Copy link
Member

SOURCE_DATE_EPOCH is a standard name already consumed by dozens of other tools

Ah I see; good to know!

@khwilliamson khwilliamson merged commit 01cd921 into perl-pod:master Aug 9, 2020
1 check passed
@khwilliamson
Copy link
Contributor

How soon do you need a release

@bmwiedemann
Copy link
Contributor Author

It is not urgent. reproducible-builds is a long-term project, so if this ends up in perl in 2021, that will be fine.

@bmwiedemann bmwiedemann deleted the date branch August 9, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants